Ashwin Kumar Sivakumar efd2ec6222 fix: wire up dead admin router, IDOR on submit_requirement, dead code cleanup ... apps/payments/src/admin.rs (tax rules, ledger, orders, credits, invoice admin endpoints) was written but never actually shipped: no `mod admin;` in main.rs, no `wallet` crate dependency in Cargo.toml, and its routes used axum 0.6-style `:id` path syntax (this workspace is on 0.8, which requires `{id}` and panics on `:id` at router-build time). Meanwhile apps/gateway explicitly forwards /api/admin/invoices*, /api/admin/tax, /api/admin/orders, /api/admin/ledger, and /api/admin/credits/* to this service, so every one of those admin endpoints has been 404ing in production. Fixed all three issues and merged the router in. Also fixed three inline SQL queries (list_ledger x2, get_credit_ledger) still selecting the nonexistent `type`/`reason` columns this session's earlier wallet-crate fix already corrected everywhere else -- these went unnoticed until now because dynamic SQL isn't checked at compile time, and the file had literally never been compiled before. apps/customers/src/handlers.rs submit_requirement had no ownership check -- every sibling handler on the same resource (get_requirement, update_requirement, mark_requirement_urgent) checks req.created_by_user_id against auth.user_id; this one didn't, so any authenticated customer could submit another customer's DRAFT requirement into the approval queue by id, with the verification case and email misattributed to the caller instead of the actual owner. Removed ProfessionalRepository::try_reserve_tracecoins/ try_debit_reserved_tracecoins/try_release_reserved_tracecoins (crates/db/src/models/professional.rs) -- a dead, unreferenced duplicate of TracecoinWalletRepository's already-correct reserve/debit/release, whose ledger INSERTs used the same nonexistent `type`/`reason` columns and would have errored at runtime if anything had ever called it. A second implementation of the same money-moving logic is itself the risk, so removed rather than fixed in place. Added the missing FK constraints on lead_requests.lead_id and .user_role_profile_id (only professional_user_id/customer_user_id had one) -- app code always populates them correctly today, but nothing DB-side stopped a future bug from writing a dangling reference. Centralized the 18% GST rate (invoice::STANDARD_GST_RATE_PERCENT) instead of the literal 18.0 duplicated at both invoice-generation call sites. Not fixed, flagged instead: the admin reconcile_credits report compares each wallet's all-time balance against a ledger sum restricted to a 30-day-by-default window -- objectively wrong, but the deeper problem is that tracecoin_ledger.amount's sign convention differs between writers (TracecoinWalletRepository stores unsigned magnitudes keyed by transaction_type; crates/wallet stores signed balance deltas directly), so a correct "balance == sum(ledger)" reconciliation needs that inconsistency resolved first -- not a quick fix, a design decision on the write side.		2026-08-18 01:44:10 +05:30
..
auth	fix payments runtime and jwt backend	2026-06-09 22:52:30 +02:00
cache	Fix security audit findings: admin authz, captcha, secret leak, CORS	2026-07-23 17:31:48 +05:30
contracts	feat(marketplace): urgent/featured leads for customers, correct request cap	2026-08-18 01:34:24 +05:30
db	fix: wire up dead admin router, IDOR on submit_requirement, dead code cleanup	2026-08-18 01:44:10 +05:30
db-migrate	feat(db): update service handlers and models for new schema	2026-04-13 00:29:44 +02:00
email	Update backend services: catering_services, companies, developers, gateway, job_seekers, photographers, social_media_managers, tutors, ugc_content_creators, users; update cache (otp, token), contracts (profession_shared, profession_state), db (job_seeker, verification), email; add revision-requested email template; update init-db.sql and start-services.sh	2026-05-08 15:34:29 +02:00
invoice	fix: wire up dead admin router, IDOR on submit_requirement, dead code cleanup	2026-08-18 01:44:10 +05:30
storage	Add presigned document URLs to stop leaking permanent Backblaze links	2026-07-27 18:07:15 +05:30
wallet	fix(wallet): fund-leak on lead rejection, broken expiry refund, dead admin_adjust	2026-08-18 00:51:19 +05:30